Bug 47543 – [Qt] Simplify code generation in WebKit2/DerivedSources.pro

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

It would be great if we have only two generator rules
similar to DerivedSources.make instead of copy/paste 
code: one for headers and one for sources.

DerivedSources.make:
...

MESSAGE_RECEIVERS = \
    PluginControllerProxy \
    PluginProcess \
    PluginProcessProxy \
    PluginProxy \
    WebPage \
    WebPageProxy \
    WebProcess \
    WebProcessConnection \
#

...

all : \
    $(MESSAGE_RECEIVERS:%=%MessageReceiver.cpp) \
    $(MESSAGE_RECEIVERS:%=%Messages.h) \
#

%MessageReceiver.cpp : %.messages.in $(SCRIPTS)
        @echo Generating messages header for $*...
        @python $(WebKit2)/Scripts/generate-message-receiver.py $< > $@

%Messages.h : %.messages.in $(SCRIPTS)
        @echo Generating message receiver for $*...
        @python $(WebKit2)/Scripts/generate-messages-header.py $< > $@

[Csaba Osztrogonác]

Created attachment 70603 [details]
proposed patch

[Csaba Osztrogonác]

Comment on attachment 70603 [details]
proposed patch

Clearing flags on attachment: 70603

Committed r69653: <http://trac.webkit.org/changeset/69653>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/69653 might have broken Qt Linux Release
The following tests are not passing:
fast/events/spatial-navigation/snav-clipped-overflowed-content.html