Bug 47543

Summary: [Qt] Simplify code generation in WebKit2/DerivedSources.pro
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, abecsi, eric, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Description Csaba Osztrogonác 2010-10-12 05:55:18 PDT
It would be great if we have only two generator rules
similar to DerivedSources.make instead of copy/paste 
code: one for headers and one for sources.

DerivedSources.make:
...

MESSAGE_RECEIVERS = \
    PluginControllerProxy \
    PluginProcess \
    PluginProcessProxy \
    PluginProxy \
    WebPage \
    WebPageProxy \
    WebProcess \
    WebProcessConnection \
#

...

all : \
    $(MESSAGE_RECEIVERS:%=%MessageReceiver.cpp) \
    $(MESSAGE_RECEIVERS:%=%Messages.h) \
#

%MessageReceiver.cpp : %.messages.in $(SCRIPTS)
        @echo Generating messages header for $*...
        @python $(WebKit2)/Scripts/generate-message-receiver.py $< > $@

%Messages.h : %.messages.in $(SCRIPTS)
        @echo Generating message receiver for $*...
        @python $(WebKit2)/Scripts/generate-messages-header.py $< > $@
Comment 1 Csaba Osztrogonác 2010-10-13 05:46:13 PDT
Created attachment 70603 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2010-10-13 06:09:46 PDT
Comment on attachment 70603 [details]
proposed patch

Clearing flags on attachment: 70603

Committed r69653: <http://trac.webkit.org/changeset/69653>
Comment 3 Csaba Osztrogonác 2010-10-13 06:09:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-10-13 06:58:24 PDT
http://trac.webkit.org/changeset/69653 might have broken Qt Linux Release
The following tests are not passing:
fast/events/spatial-navigation/snav-clipped-overflowed-content.html