Bug 47534

Summary: commit-queue should reject patches which fail ewses
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, levin, mihai, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-10-11 20:33:24 PDT
commit-queue should reject patches which fail stylebot

Per Oliver's request on webkit-reviewers.  Makes sense to me.

Should be easy to make the cq check stylebot status before landing.  Alternatively we could have the style-bot simply cq- any patch which fails.  They're slightly different meanings.  Not sure which is the more useful.
Comment 1 Eric Seidel (no email) 2011-05-05 01:05:36 PDT
After further thought, we've decided to make the EWSes reject from the cq, but not the style-bot.
Comment 2 Eric Seidel (no email) 2011-05-05 01:06:08 PDT
We can always add the style-bot later, but breaking the build or tests is a better reason not to land than breaking style rules atm. :)
Comment 3 Eric Seidel (no email) 2011-05-05 02:09:04 PDT
Created attachment 92391 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-05-05 10:59:50 PDT
To be clear, what this does is when an EWS fails, it marks the patch as cq-.  That *does not* prevent someone from marking it cq+ later, or landing manually.  So this is mostly just a stronger form of advisement.  I don't think most people will notice, but hopefullly it will further convey the idea that patches shouldn't break builders. :)

Also this moves us one step closer to making test running asynchronous from landing (which will make the cq blazing fast, and is more like how a real person codes).
Comment 5 WebKit Commit Bot 2011-05-05 13:18:57 PDT
Comment on attachment 92391 [details]
Patch

Clearing flags on attachment: 92391

Committed r85871: <http://trac.webkit.org/changeset/85871>
Comment 6 WebKit Commit Bot 2011-05-05 13:19:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-05-05 16:06:48 PDT
http://trac.webkit.org/changeset/85871 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-46-t.svg