Bug 47530

Summary: IndexedDB should fire some errors synchronously
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, commit-queue, dglazkov, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jeremy Orlow
Reported 2010-10-11 18:28:20 PDT
IndexedDB should fire some errors synchronously
Attachments
Patch (132.75 KB, patch)
2010-10-11 18:44 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (131.53 KB, patch)
2010-10-13 10:26 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (131.42 KB, patch)
2010-10-13 10:55 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-10-11 18:44:46 PDT
Created attachment 70509 [details] Patch
WebKit Review Bot
Comment 2 2010-10-11 21:43:51 PDT
Attachment 70509 [details] did not build on chromium: Build output: http://queues.webkit.org/results/4337039
Jeremy Orlow
Comment 3 2010-10-13 00:24:23 PDT
Andrei, can you please review this?
Jeremy Orlow
Comment 4 2010-10-13 10:26:41 PDT
Created attachment 70622 [details] Patch
Nate Chapin
Comment 5 2010-10-13 10:40:38 PDT
Comment on attachment 70622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70622&action=review > LayoutTests/storage/indexeddb/objectstore-basics.html:64 > shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object! Does this null check still make sense if we already know we're failing? It's not entirely clear to me. > LayoutTests/storage/indexeddb/objectstore-basics.html:87 > + shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object! Same as above.
Jeremy Orlow
Comment 6 2010-10-13 10:42:19 PDT
(In reply to comment #5) > (From update of attachment 70622 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70622&action=review > > > LayoutTests/storage/indexeddb/objectstore-basics.html:64 > > shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object! > > Does this null check still make sense if we already know we're failing? It's not entirely clear to me. > > > LayoutTests/storage/indexeddb/objectstore-basics.html:87 > > + shouldBeNull("index"); // Returning null is wrong, but less wrong than returning an actual object! > > Same as above. I could go either way, but I'm happy to delete it.
Jeremy Orlow
Comment 7 2010-10-13 10:55:49 PDT
Created attachment 70629 [details] Patch
WebKit Commit Bot
Comment 8 2010-10-13 17:39:48 PDT
Comment on attachment 70629 [details] Patch Clearing flags on attachment: 70629 Committed r69721: <http://trac.webkit.org/changeset/69721>
WebKit Commit Bot
Comment 9 2010-10-13 17:39:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.