Bug 47519

Summary: [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem.
Product: WebKit Reporter: Kavita Kanetkar <kkanetkar>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dumi, ericu, eric, kinuko, michaeln, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch2 none

Kavita Kanetkar
Reported 2010-10-11 17:03:39 PDT
Currently FileSyetem will create root path of the file system if one does not exist. There are cases such as Inspector opening the file system. In these cases we do not want to create the file system root paths.
Attachments
patch (8.80 KB, patch)
2010-10-11 18:29 PDT, Kavita Kanetkar 		no flags
DetailsFormatted DiffDiff
patch2 (2.57 KB, patch)
2010-10-12 14:48 PDT, Kavita Kanetkar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kavita Kanetkar
Comment 1 2010-10-11 18:29:56 PDT
Created attachment 70508 [details] patch
Dumitru Daniliuc
Comment 2 2010-10-12 11:02:55 PDT
Comment on attachment 70508 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=70508&action=review > WebKit/chromium/src/LocalFileSystemChromium.cpp:71 > + webWorker->openFileSystem(static_cast<WebFileSystem::Type>(type), size, create, new WebFileSystemCallbacksImpl(callbacks, context, synchronous), create, synchronous); why do we need to pass the 'create' arg twice?
Kavita Kanetkar
Comment 3 2010-10-12 14:48:25 PDT
Created attachment 70565 [details] patch2 Simplified this. Added new method so that chromium uses them. Will upload another patch for WebCore to use new method signatures. Thanks for the review.
Dumitru Daniliuc
Comment 4 2010-10-12 14:49:38 PDT
Comment on attachment 70565 [details] patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=70565&action=review r=me. > WebKit/chromium/ChangeLog:5 > + [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem. please update description.
Dumitru Daniliuc
Comment 5 2010-10-12 14:51:27 PDT
Comment on attachment 70565 [details] patch2 oops, ignore my comment. cq+'ing.
WebKit Commit Bot
Comment 6 2010-10-12 15:06:05 PDT
Comment on attachment 70565 [details] patch2 Clearing flags on attachment: 70565 Committed r69609: <http://trac.webkit.org/changeset/69609>
WebKit Commit Bot
Comment 7 2010-10-12 15:06:10 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-10-12 16:09:28 PDT
http://trac.webkit.org/changeset/69609 might have broken Chromium Win Release
Eric Seidel (no email)
Comment 9 2010-10-12 16:56:07 PDT
enums are always better than bools.
Note You need to log in before you can comment on or make changes to this bug.