Bug 47493

Summary: Kill Path::debugString()
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, mdelaney7, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 18994    
Attachments:
Description Flags
Patch
kling: review-
Patch v2 none

Nikolas Zimmermann
Reported 2010-10-11 09:59:05 PDT
Remove pathDebugString(), it's obsolete now.
Attachments
Patch (15.05 KB, patch)
2010-10-11 10:02 PDT, Nikolas Zimmermann 		kling: review-
DetailsFormatted DiffDiff
Patch v2 (15.83 KB, patch)
2010-10-11 10:24 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-10-11 10:02:07 PDT
Created attachment 70441 [details] Patch
WebKit Review Bot
Comment 2 2010-10-11 10:03:16 PDT
Attachment 70441 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/svg/SVGGlyphElement.h:83: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2010-10-11 10:03:32 PDT
*** Bug 47457 has been marked as a duplicate of this bug. ***
Andreas Kling
Comment 4 2010-10-11 10:04:14 PDT
Comment on attachment 70441 [details] Patch Nice, r=me
Andreas Kling
Comment 5 2010-10-11 10:08:38 PDT
Comment on attachment 70441 [details] Patch Hold up, this will only work on Qt where platformPath() is a non-pointer!
Nikolas Zimmermann
Comment 6 2010-10-11 10:24:29 PDT
Created attachment 70448 [details] Patch v2
Andreas Kling
Comment 7 2010-10-11 10:25:23 PDT
Comment on attachment 70448 [details] Patch v2 LGTM.
Andreas Kling
Comment 8 2010-10-11 10:26:17 PDT
(Note: After discussion on IRC, we realized that comparing the paths in SVGGlyphIdentifier was pointless anyway.)
Nikolas Zimmermann
Comment 9 2010-10-11 10:27:56 PDT
Landed in r69505.
Andreas Kling
Comment 10 2010-10-14 05:47:23 PDT
Comment on attachment 70448 [details] Patch v2 Removing from pending-commit since it was landed in r69505.
Note You need to log in before you can comment on or make changes to this bug.