Summary: | Kill Path::debugString() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kling, mdelaney7, webkit.review.bot, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 18994 | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-10-11 09:59:05 PDT
Created attachment 70441 [details]
Patch
Attachment 70441 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/svg/SVGGlyphElement.h:83: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 47457 has been marked as a duplicate of this bug. *** Comment on attachment 70441 [details]
Patch
Nice, r=me
Comment on attachment 70441 [details]
Patch
Hold up, this will only work on Qt where platformPath() is a non-pointer!
Created attachment 70448 [details]
Patch v2
Comment on attachment 70448 [details]
Patch v2
LGTM.
(Note: After discussion on IRC, we realized that comparing the paths in SVGGlyphIdentifier was pointless anyway.) Comment on attachment 70448 [details] Patch v2 Removing from pending-commit since it was landed in r69505. |