Summary: | Add 'didDraw' callback to WebKit for framerate tracking | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | ASSIGNED --- | ||||||||||
Severity: | Normal | CC: | abarth, bdakin, sam, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | Windows 7 | ||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-10-10 19:25:19 PDT
Created attachment 70562 [details]
Patch
http://trac.webkit.org/changeset/69600 for Mac. Keeping open for Windows and WebKit2. Comment on attachment 70562 [details] Patch Cleared Sam Weinig's review+ from obsolete attachment 70562 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 70903 [details]
Patch
Attachment 70903 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:163: Extra space between WKPageDidDraw and didDraw [whitespace/declaration] [3]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 70903 [details] did not build on qt: Build output: http://queues.webkit.org/results/4456051 Created attachment 70905 [details]
Patch
Comment on attachment 70905 [details] Patch http://trac.webkit.org/changeset/69892 Keep open for Windows. To be clear, this is for the embedder, not for JavaScript, right? Correct. Is this still needed? |