Bug 47478

Summary: Add 'didDraw' callback to WebKit for framerate tracking
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: ASSIGNED    
Severity: Normal CC: abarth, bdakin, sam, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2010-10-10 19:25:19 PDT
In order to track the rate at which the WebView is drawing to the screen, we need a 'didDraw' callback.
Attachments
Patch (1.77 KB, patch)
2010-10-12 13:56 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2010-10-15 15:09 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.68 KB, patch)
2010-10-15 15:20 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-10-12 13:56:23 PDT
Created attachment 70562 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-10-12 14:07:53 PDT
http://trac.webkit.org/changeset/69600 for Mac. Keeping open for Windows and WebKit2.
Eric Seidel (no email)
Comment 3 2010-10-14 07:19:32 PDT
Comment on attachment 70562 [details] Patch Cleared Sam Weinig's review+ from obsolete attachment 70562 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Simon Fraser (smfr)
Comment 4 2010-10-15 15:09:07 PDT
Created attachment 70903 [details] Patch
WebKit Review Bot
Comment 5 2010-10-15 15:12:03 PDT
Attachment 70903 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:163: Extra space between WKPageDidDraw and didDraw [whitespace/declaration] [3] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 6 2010-10-15 15:16:54 PDT
Attachment 70903 [details] did not build on qt: Build output: http://queues.webkit.org/results/4456051
Simon Fraser (smfr)
Comment 7 2010-10-15 15:20:12 PDT
Created attachment 70905 [details] Patch
Simon Fraser (smfr)
Comment 8 2010-10-15 15:35:07 PDT
Comment on attachment 70905 [details] Patch http://trac.webkit.org/changeset/69892
Simon Fraser (smfr)
Comment 9 2010-10-15 15:36:16 PDT
Keep open for Windows.
Adam Barth
Comment 10 2010-10-18 15:55:50 PDT
To be clear, this is for the embedder, not for JavaScript, right?
Simon Fraser (smfr)
Comment 11 2010-10-18 16:35:19 PDT
Correct.
Alexey Proskuryakov
Comment 12 2013-10-03 11:57:13 PDT
Is this still needed?
Note You need to log in before you can comment on or make changes to this bug.