| Summary: | Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
| Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, mrobinson, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Antonio Gomes
2010-10-10 11:48:19 PDT
Created attachment 70435 [details] (committed r69515, r=kling) patch v1 Patch converts the editing/selection/click-in-padding-with-multiple-line-boxes.js to make use of the LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior code paths can be test in the same execution, and we make it possible to share the same expected result file through all ports. Comment on attachment 70435 [details] (committed r69515, r=kling) patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=70435&action=review LGTM. > LayoutTests/editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:52 > // Later we could break this into two tests, one that tests each platform's rules, > // since this is supported as a setting in the Settings object, but for now, we'll > // just use separate expected results for Mac and other platforms. Seems like this comment should be deleted now. Comment on attachment 70435 [details] (committed r69515, r=kling) patch v1 Clearing flags on attachment: 70435. Committed r69515: <http://trac.webkit.org/changeset/69515> http://trac.webkit.org/changeset/69515 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/js/basic-strict-mode.html |