Bug 47472 - Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior
Summary: Convert editing/selection/script-tests/click-in-padding-with-multiple-line-bo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
Depends on:
Reported: 2010-10-10 11:48 PDT by Antonio Gomes
Modified: 2010-10-11 14:29 PDT (History)
5 users (show)

See Also:

(committed r69515, r=kling) patch v1 (9.82 KB, patch)
2010-10-11 07:45 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-10-10 11:48:19 PDT
... that way we can share the same expected result to all platforms.
Comment 1 Antonio Gomes 2010-10-11 07:45:33 PDT
Created attachment 70435 [details]
(committed r69515, r=kling) patch v1

 Patch converts the editing/selection/click-in-padding-with-multiple-line-boxes.js to make use of the LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior code paths can be test in the same execution, and we make it possible to share the same expected result file through all ports.
Comment 2 Andreas Kling 2010-10-11 07:48:29 PDT
Comment on attachment 70435 [details]
(committed r69515, r=kling) patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=70435&action=review


> LayoutTests/editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:52
>  // Later we could break this into two tests, one that tests each platform's rules,
>  // since this is supported as a setting in the Settings object, but for now, we'll
>  // just use separate expected results for Mac and other platforms.

Seems like this comment should be deleted now.
Comment 3 Antonio Gomes 2010-10-11 12:16:48 PDT
Comment on attachment 70435 [details]
(committed r69515, r=kling) patch v1

Clearing flags on attachment: 70435.

Committed r69515: <http://trac.webkit.org/changeset/69515>
Comment 4 WebKit Review Bot 2010-10-11 14:29:28 PDT
http://trac.webkit.org/changeset/69515 might have broken GTK Linux 32-bit Release
The following tests are not passing: