Bug 47468

Summary: editing/selection/extend-after-mouse-selection.html should use LayoutTestController::setEditingBehavior
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
(committed r69466, r=kling) patch v1 none

Description Antonio Gomes 2010-10-10 04:42:41 PDT
That way we could get rid of platform specific expected result files:

$ find . -name extend-after-mouse-selection*./editing/selection/extend-after-mouse-selection.html
./platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt
./platform/mac/editing/selection/extend-after-mouse-selection-expected.txt
./platform/win/editing/selection/extend-after-mouse-selection-expected.txt
Comment 1 Antonio Gomes 2010-10-10 05:45:23 PDT
Created attachment 70395 [details]
(committed r69466, r=kling) patch v1

 Patch changed editing/selection/extend-after-mouse-selection.html to use the LayoutTestController::setEditingBehavior machinary. It makes it possible to remove platform dependent test results by testing through all platform-specific codepath's we have.
Comment 2 Andreas Kling 2010-10-10 05:56:46 PDT
Comment on attachment 70395 [details]
(committed r69466, r=kling) patch v1

LGTM
Comment 3 Antonio Gomes 2010-10-10 08:28:37 PDT
Comment on attachment 70395 [details]
(committed r69466, r=kling) patch v1

Clearing review flags on attachment: 70395.

Committed r69466: http://trac.webkit.org/changeset/69466