[Qt] Compile fails when building qtwebkit with the "--v8" option...

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Dawit A.]

Because of the following #include sequence in the generated webkit v8 source files:
V8Proxy.h -> PlatformBridge.h -> npapi.h -> Xlib.h -> X.h

That sequence leads to the word "None" being defined as 


#ifndef None
#define None                 0L /* universal null resource or null atom */
#endif

in X.h. Unfortunately that leads to the "None" in "v8::None" enum values being changed to v8::0L by the gcc preprocessor...

[Dawit A.]

Created attachment 70366 [details]
Proposed patch to fix compile issue...

[Andreas Kling]

Comment on attachment 70366 [details]
Proposed patch to fix compile issue...

View in context: https://bugs.webkit.org/attachment.cgi?id=70366&action=review

> WebCore/platform/qt/PlatformBridge.h:80
>  class NPObject;
> +class NPP;

Snag this from ChromiumBridge.h instead:

typedef struct NPObject NPObject;
typedef struct _NPP NPP_t;
typedef NPP_t* NPP;

[Dawit A.]

Created attachment 70368 [details]
Proposed patch [Update 1]...

[Andreas Kling]

Comment on attachment 70368 [details]
Proposed patch [Update 1]...

r=me

[WebKit Commit Bot]

Comment on attachment 70368 [details]
Proposed patch [Update 1]...

Clearing flags on attachment: 70368

Committed r69791: <http://trac.webkit.org/changeset/69791>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.