Bug 47441

Summary:

[GTK] Search field icons should be centered vertically in the field

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

xan.lopez

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Search field icon that is not centered	none
Patch for this issue	none
Patch clarifying rounding and reducing duplicated code	xan.lopez: review+

Martin Robinson

Reported 2010-10-08 16:46:03 PDT

Currently search field icons seem to be drawn at some fixed distance from the top of the text field. See attached screenshot for demonstration of the issue.

Attachments
Search field icon that is not centered (5.34 KB, image/png) 2010-10-08 16:47 PDT, Martin Robinson	no flags	Details
Patch for this issue (17.49 KB, patch) 2010-10-08 17:00 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Patch clarifying rounding and reducing duplicated code (17.61 KB, patch) 2010-10-09 13:29 PDT, Martin Robinson	xan.lopez: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-10-08 16:47:19 PDT

Created attachment 70317 [details] Search field icon that is not centered

Martin Robinson

Comment 2 2010-10-08 17:00:29 PDT

Created attachment 70319 [details] Patch for this issue

Xan Lopez

Comment 3 2010-10-09 02:43:34 PDT

Comment on attachment 70319 [details] Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=70319&action=review > WebCore/platform/gtk/RenderThemeGtk.cpp:528 > + } What's the + 1 for? :)

Martin Robinson

Comment 4 2010-10-09 08:20:18 PDT

For text boxes with height that are an even number of pixels, it rounds to the bottom of the two central pixels. It originates from the Chromium port and they had a comment about this, so I definitely need to add one here. I will. :)

Martin Robinson

Comment 5 2010-10-09 13:29:45 PDT

Created attachment 70369 [details] Patch clarifying rounding and reducing duplicated code

Martin Robinson

Comment 6 2010-10-11 08:24:42 PDT

Committed r69495: <http://trac.webkit.org/changeset/69495>

Note You need to log in before you can comment on or make changes to this bug.