Bug 47435

Summary:

[GTK] Slider padding translate into a larger track rect

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Screenshot showing padding issue	none
Patch for this issue	none

Martin Robinson

Reported 2010-10-08 15:55:31 PDT

When a range widget has padding, the padding is added to the track rect drawing area. For some themes this results in wildy incorrect rendering. See attached render.

Attachments
Screenshot showing padding issue (5.04 KB, image/png) 2010-10-08 15:56 PDT, Martin Robinson	no flags	Details
Patch for this issue (6.32 KB, patch) 2010-10-08 16:01 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2010-10-08 15:56:24 PDT

Created attachment 70307 [details] Screenshot showing padding issue

Martin Robinson

Comment 2 2010-10-08 16:01:36 PDT

Created attachment 70310 [details] Patch for this issue

Martin Robinson

Comment 3 2010-10-08 16:02:42 PDT

I've uploaded a patch for this issue. The rectangle size is still not entirely correct (we should be getting some padding values from the widget style to inflate the track rect), but with this patch it is much closer.

Martin Robinson

Comment 4 2010-10-09 08:17:33 PDT

Comment on attachment 70310 [details] Patch for this issue Clearing flags on attachment: 70310 Committed r69447: <http://trac.webkit.org/changeset/69447>

Martin Robinson

Comment 5 2010-10-09 08:17:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.