Summary: | [Qt] TestController needs its platform dependent methods | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Balazs Kelemen
2010-10-08 06:16:32 PDT
Created attachment 70240 [details]
Patch
Created attachment 70241 [details]
Patch
Fixed the Changelog
Comment on attachment 70241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70241&action=review > WebKitTools/ChangeLog:5 > + [Qt] TestController needs it's platform dependent methods s/it's/its/ > WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:90 > + QString path = libPathFromEnv ? QLatin1String(libPathFromEnv) > + : QCoreApplication::applicationDirPath() + "/../lib/libWTRInjectedBundle.so"; This is platform-specific and needs to be cleaned up. Created attachment 70251 [details]
Patch
Oh, I forgot to clean up the changelog. I would do this before landing. Comment on attachment 70251 [details]
Patch
LGTM.
Committed r69401: <http://trac.webkit.org/changeset/69401> Comment on attachment 70251 [details]
Patch
Clearing flags
|