Bug 47413

Summary: [Qt] TestController needs its platform dependent methods
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Balazs Kelemen
Reported 2010-10-08 06:16:32 PDT
We need to implement initializeInjectedBundlePath and initializeTestPluginDirectory for a working WTR.
Attachments
Patch (3.56 KB, patch)
2010-10-08 06:23 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2010-10-08 06:32 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2010-10-08 08:02 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-10-08 06:23:13 PDT
Created attachment 70240 [details] Patch
Balazs Kelemen
Comment 2 2010-10-08 06:32:51 PDT
Created attachment 70241 [details] Patch Fixed the Changelog
Andreas Kling
Comment 3 2010-10-08 07:30:59 PDT
Comment on attachment 70241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70241&action=review > WebKitTools/ChangeLog:5 > + [Qt] TestController needs it's platform dependent methods s/it's/its/ > WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:90 > + QString path = libPathFromEnv ? QLatin1String(libPathFromEnv) > + : QCoreApplication::applicationDirPath() + "/../lib/libWTRInjectedBundle.so"; This is platform-specific and needs to be cleaned up.
Balazs Kelemen
Comment 4 2010-10-08 08:02:00 PDT
Created attachment 70251 [details] Patch
Balazs Kelemen
Comment 5 2010-10-08 08:04:18 PDT
Oh, I forgot to clean up the changelog. I would do this before landing.
Andreas Kling
Comment 6 2010-10-08 08:11:18 PDT
Comment on attachment 70251 [details] Patch LGTM.
Balazs Kelemen
Comment 7 2010-10-08 08:27:35 PDT
Committed r69401: <http://trac.webkit.org/changeset/69401>
Balazs Kelemen
Comment 8 2010-10-08 08:30:21 PDT
Comment on attachment 70251 [details] Patch Clearing flags
Note You need to log in before you can comment on or make changes to this bug.