Bug 47413

Summary: [Qt] TestController needs its platform dependent methods
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Balazs Kelemen 2010-10-08 06:16:32 PDT
We need to implement initializeInjectedBundlePath and initializeTestPluginDirectory for a working WTR.
Comment 1 Balazs Kelemen 2010-10-08 06:23:13 PDT
Created attachment 70240 [details]
Patch
Comment 2 Balazs Kelemen 2010-10-08 06:32:51 PDT
Created attachment 70241 [details]
Patch

Fixed the Changelog
Comment 3 Andreas Kling 2010-10-08 07:30:59 PDT
Comment on attachment 70241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70241&action=review

> WebKitTools/ChangeLog:5
> +        [Qt] TestController needs it's platform dependent methods

s/it's/its/

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:90
> +    QString path = libPathFromEnv ? QLatin1String(libPathFromEnv)
> +                                  : QCoreApplication::applicationDirPath() + "/../lib/libWTRInjectedBundle.so";

This is platform-specific and needs to be cleaned up.
Comment 4 Balazs Kelemen 2010-10-08 08:02:00 PDT
Created attachment 70251 [details]
Patch
Comment 5 Balazs Kelemen 2010-10-08 08:04:18 PDT
Oh, I forgot to clean up the changelog. I would do this before landing.
Comment 6 Andreas Kling 2010-10-08 08:11:18 PDT
Comment on attachment 70251 [details]
Patch

LGTM.
Comment 7 Balazs Kelemen 2010-10-08 08:27:35 PDT
Committed r69401: <http://trac.webkit.org/changeset/69401>
Comment 8 Balazs Kelemen 2010-10-08 08:30:21 PDT
Comment on attachment 70251 [details]
Patch

Clearing flags