Bug 47413 - [Qt] TestController needs its platform dependent methods
Summary: [Qt] TestController needs its platform dependent methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-08 06:16 PDT by Balazs Kelemen
Modified: 2010-10-08 08:30 PDT (History)
0 users

See Also:


Attachments
Patch (3.56 KB, patch)
2010-10-08 06:23 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
Patch (3.09 KB, patch)
2010-10-08 06:32 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2010-10-08 08:02 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-10-08 06:16:32 PDT
We need to implement initializeInjectedBundlePath and initializeTestPluginDirectory for a working WTR.
Comment 1 Balazs Kelemen 2010-10-08 06:23:13 PDT
Created attachment 70240 [details]
Patch
Comment 2 Balazs Kelemen 2010-10-08 06:32:51 PDT
Created attachment 70241 [details]
Patch

Fixed the Changelog
Comment 3 Andreas Kling 2010-10-08 07:30:59 PDT
Comment on attachment 70241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70241&action=review

> WebKitTools/ChangeLog:5
> +        [Qt] TestController needs it's platform dependent methods

s/it's/its/

> WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:90
> +    QString path = libPathFromEnv ? QLatin1String(libPathFromEnv)
> +                                  : QCoreApplication::applicationDirPath() + "/../lib/libWTRInjectedBundle.so";

This is platform-specific and needs to be cleaned up.
Comment 4 Balazs Kelemen 2010-10-08 08:02:00 PDT
Created attachment 70251 [details]
Patch
Comment 5 Balazs Kelemen 2010-10-08 08:04:18 PDT
Oh, I forgot to clean up the changelog. I would do this before landing.
Comment 6 Andreas Kling 2010-10-08 08:11:18 PDT
Comment on attachment 70251 [details]
Patch

LGTM.
Comment 7 Balazs Kelemen 2010-10-08 08:27:35 PDT
Committed r69401: <http://trac.webkit.org/changeset/69401>
Comment 8 Balazs Kelemen 2010-10-08 08:30:21 PDT
Comment on attachment 70251 [details]
Patch

Clearing flags