Bug 47402

Summary: [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, ossy, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Andras Becsi
Reported 2010-10-08 03:05:53 PDT
Add missing implementation of WTR::activateFonts() to WebKitTestRunner's InjectedBundle.
Attachments
proposed patch (4.44 KB, patch)
2010-10-08 03:19 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
proposed patch (4.44 KB, patch)
2010-10-08 03:41 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2010-10-08 03:19:30 PDT
Created attachment 70218 [details] proposed patch Add missing file which was already added to the project file in a previous stage of the upstreaming.
WebKit Review Bot
Comment 2 2010-10-08 03:26:13 PDT
Attachment 70218 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:30: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:69: Declaration has space between type name and * in FcConfig *config [whitespace/declaration] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andras Becsi
Comment 3 2010-10-08 03:41:18 PDT
Created attachment 70220 [details] proposed patch Fixed the misplaced * and WebKit2 does not a config.h.
WebKit Review Bot
Comment 4 2010-10-08 03:49:35 PDT
Attachment 70220 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:30: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Rohde Christiansen
Comment 5 2010-10-08 04:35:28 PDT
Comment on attachment 70220 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=70220&action=review > WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:43 > +{ > + unneeded newline here > WebKitTools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:81 > + > +} Here as well
Andras Becsi
Comment 6 2010-10-08 05:29:40 PDT
Committed r69392: <http://trac.webkit.org/changeset/69392>
Andras Becsi
Comment 7 2010-10-08 05:30:30 PDT
Comment on attachment 70220 [details] proposed patch Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.