Bug 47385

Summary: Copy mesa lib into DumpRenderTree bundle in Mac
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, enne, kbr, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
tony: review-, zmo: commit-queue-
revised patch: responding to Tony Chang's review tony: review+, zmo: commit-queue-

Zhenyao Mo
Reported 2010-10-07 17:10:01 PDT
Currently the code assumes mesa lib is there (which isn't), so DumpRenderTree is not using Mesa at the moment in Mac
Attachments
patch (1.97 KB, patch)
2010-10-07 17:12 PDT, Zhenyao Mo 		tony: review-
zmo: commit-queue-
DetailsFormatted DiffDiff
revised patch: responding to Tony Chang's review (1.58 KB, patch)
2010-10-07 17:44 PDT, Zhenyao Mo 		tony: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-10-07 17:12:33 PDT
Created attachment 70175 [details] patch
Tony Chang
Comment 2 2010-10-07 17:24:50 PDT
Comment on attachment 70175 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=70175&action=review > WebKit/chromium/WebKit.gyp:810 > + 'target_name': 'mesa', Can you move this target to the OS=="mac" section at the bottom of the file (next to LayoutTestHelper)? > WebKit/chromium/WebKit.gyp:830 > + 'mesa', And this will then move next to the LayoutTestHelper dependencies (around line 895). > WebKit/chromium/WebKit.gyp:-819 > - '<(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa', Then you can keep this line since win/linux needs it.
Zhenyao Mo
Comment 3 2010-10-07 17:44:35 PDT
Created attachment 70180 [details] revised patch: responding to Tony Chang's review Also, I changed the target name from mesa to copy_mesa
Tony Chang
Comment 4 2010-10-07 17:46:15 PDT
Comment on attachment 70180 [details] revised patch: responding to Tony Chang's review LGTM!
Zhenyao Mo
Comment 5 2010-10-07 17:55:03 PDT
Committed r69365: <http://trac.webkit.org/changeset/69365>
Note You need to log in before you can comment on or make changes to this bug.