Bug 47367

Summary: [GTK] Remove duplicate code in WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue xan.lopez: review+

Martin Robinson
Reported 2010-10-07 11:41:35 PDT
r69290 introduced some duplicate code into WebKit/gtk/WebCoreSupport/DragClientGtk.cpp. This bug tracks removing it.
Attachments
Patch for this issue (5.86 KB, patch)
2010-10-07 11:46 PDT, Martin Robinson 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-10-07 11:46:07 PDT
Created attachment 70126 [details] Patch for this issue
Carlos Garcia Campos
Comment 2 2010-10-08 00:01:49 PDT
In if (!gdk_cairo_get_clip_rectangle(cr, &clipRect)). Since we are not using clipRect and gdk_cairo_get_clip_rectangle() accepts NULL, Xan suggested to use NULL rather than a varaible.
Xan Lopez
Comment 3 2010-10-08 03:13:27 PDT
Comment on attachment 70126 [details] Patch for this issue Looks good to me, you can do what carlos suggests when committing.
Martin Robinson
Comment 4 2010-10-08 09:02:11 PDT
Thanks for the review. I will make the change before landing.
Martin Robinson
Comment 5 2010-10-08 09:02:37 PDT
Committed r69403: <http://trac.webkit.org/changeset/69403>
Note You need to log in before you can comment on or make changes to this bug.