Bug 47360

Summary: Web Inspector: all native breakpoints should inherit from NativeBreakpoint
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. pfeldman: review+

Description Pavel Podivilov 2010-10-07 10:19:29 PDT 
Web Inspector: all native breakpoints should inherit from NativeBreakpoint

DOM, EventListener and XHR breakpoints should be subclasses of NativeBreakpoint. Stuff that depends on breakpoint type, should be implemented in corresponding subclass.
Comment 1 Pavel Podivilov 2010-10-07 10:25:56 PDT 
Created attachment 70112 [details]
Patch.
Comment 2 Pavel Feldman 2010-10-08 08:32:04 PDT 
Comment on attachment 70112 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=70112&action=review

> WebCore/inspector/InspectorDOMAgent.cpp:781
> +    pair<long, long> breakpoint = m_idToBreakpoint.take(breakpointId);

Could you typedef this in header so that we knew what is going on.

> WebCore/inspector/front-end/BreakpointManager.js:138
> +        if (!(nodeId in this._domPathCache))

Please add // FIXME:
Comment 3 Pavel Podivilov 2010-10-12 02:36:00 PDT 
Committed r69567: <http://trac.webkit.org/changeset/69567>