Bug 47349

Summary: [Qt] Turn on building WTR
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Balazs Kelemen
Reported 2010-10-07 07:17:23 PDT
WTR build has been stabilized since r69297 (and it's follow up build-fixes) so we can turn it on.
Attachments
Patch (1.21 KB, patch)
2010-10-07 07:19 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2010-10-08 09:09 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-10-07 07:19:04 PDT
Created attachment 70084 [details] Patch
Balazs Kelemen
Comment 2 2010-10-07 07:36:08 PDT
Comment on attachment 70084 [details] Patch Clearing flags on attachment: 70084 Committed r69306: <http://trac.webkit.org/changeset/69306>
Balazs Kelemen
Comment 3 2010-10-07 07:36:16 PDT
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 4 2010-10-08 09:03:42 PDT
We have turned it off again while worked on InjectedBundle. Now we have everything in, and WTR is functional: you can give a html file to that (with absolute path) and it will dump that out. Hurray! Turn it on!
Balazs Kelemen
Comment 5 2010-10-08 09:09:49 PDT
Created attachment 70256 [details] Patch
Csaba Osztrogonác
Comment 6 2010-10-08 09:13:33 PDT
Comment on attachment 70256 [details] Patch Great work, guys! r=me
Andras Becsi
Comment 7 2010-10-08 09:15:07 PDT
(In reply to comment #4) > We have turned it off again while worked on InjectedBundle. Now we have everything in, and WTR is functional: you can give a html file to that (with absolute path) and it will dump that out. Hurray! Turn it on! Further more WebKitTools/Scripts/run-webkit-tests -2 can also be used to run the layout tests with WTR. There are still many tests failing, which need investigation, but setting up a bot should be easy now.
Balazs Kelemen
Comment 8 2010-10-08 09:16:30 PDT
Comment on attachment 70256 [details] Patch Clearing flags on attachment: 70256 Committed r69405: <http://trac.webkit.org/changeset/69405>
Balazs Kelemen
Comment 9 2010-10-08 09:16:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.