Bug 47349 - [Qt] Turn on building WTR
Summary: [Qt] Turn on building WTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-07 07:17 PDT by Balazs Kelemen
Modified: 2010-10-08 09:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2010-10-07 07:19 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2010-10-08 09:09 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-10-07 07:17:23 PDT 
WTR build has been stabilized since r69297 (and it's follow up build-fixes) so we can turn it on.
Comment 1 Balazs Kelemen 2010-10-07 07:19:04 PDT 
Created attachment 70084 [details]
Patch
Comment 2 Balazs Kelemen 2010-10-07 07:36:08 PDT 
Comment on attachment 70084 [details]
Patch

Clearing flags on attachment: 70084

Committed r69306: <http://trac.webkit.org/changeset/69306>
Comment 3 Balazs Kelemen 2010-10-07 07:36:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Balazs Kelemen 2010-10-08 09:03:42 PDT 
We have turned it off again while worked on InjectedBundle. Now we have everything in, and WTR is functional: you can give a html file to that (with absolute path) and it will dump that out. Hurray! Turn it on!
Comment 5 Balazs Kelemen 2010-10-08 09:09:49 PDT 
Created attachment 70256 [details]
Patch
Comment 6 Csaba Osztrogonác 2010-10-08 09:13:33 PDT 
Comment on attachment 70256 [details]
Patch

Great work, guys! r=me
Comment 7 Andras Becsi 2010-10-08 09:15:07 PDT 
(In reply to comment #4)
> We have turned it off again while worked on InjectedBundle. Now we have everything in, and WTR is functional: you can give a html file to that (with absolute path) and it will dump that out. Hurray! Turn it on!

Further more WebKitTools/Scripts/run-webkit-tests -2 can also be used to run the layout tests with WTR.
There are still many tests failing, which need investigation, but setting up a bot should be easy now.
Comment 8 Balazs Kelemen 2010-10-08 09:16:30 PDT 
Comment on attachment 70256 [details]
Patch

Clearing flags on attachment: 70256

Committed r69405: <http://trac.webkit.org/changeset/69405>
Comment 9 Balazs Kelemen 2010-10-08 09:16:42 PDT 
All reviewed patches have been landed.  Closing bug.