Bug 47341

Summary:

Autocorrection panel regression tests fail on Windows

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, bweinstein, commit-queue, jiapu.mail

Priority:

Keywords:

InRadar, LayoutTestFailure, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

URL:

http://build.webkit.org/results/Windows%20Release%20(Tests)/r69294%20(4891)/results.html

Attachments:

Description	Flags
Proposed patch (v1)	adele: review-, commit-queue: commit-queue-
Proposed patch (v1)	adele: review+, adele: commit-queue-

Adam Roben (:aroben)

Reported 2010-10-07 05:47:50 PDT

http://trac.webkit.org/changeset/69269 added tests for the autocorrection panel. These tests have been failing on Windows since they were added. The autocorrection panel is a Mac-only feature. Presumably that means these tests should be in platform/mac, so that they will only run on Mac.

Attachments
Proposed patch (v1) (16.32 KB, patch) 2010-10-07 13:00 PDT, Jia Pu	adele: review- commit-queue: commit-queue-	Details Formatted Diff Diff
Proposed patch (v1) (20.54 KB, patch) 2010-10-07 15:48 PDT, Jia Pu	adele: review+ adele: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2010-10-07 05:48:32 PDT

<rdar://problem/8523631>

Adam Roben (:aroben)

Comment 2 2010-10-07 05:49:50 PDT

The other option is to just check in Windows-specific results for the tests. We should do that if we think the tests are meaningful on Windows even though it doesn't have an autocorrection panel feature. Maybe that's the right thing to do, since in the Star Trek future one could be added?

Adele Peterson

Comment 3 2010-10-07 09:24:22 PDT

Sorry for not catching this earlier. Adam is right - these tests should be moved to platform/mac

Adam Roben (:aroben)

Comment 4 2010-10-07 09:31:55 PDT

(In reply to comment #3) > Sorry for not catching this earlier. Adam is right - these tests should be moved to platform/mac I guess that means you think that is a better option than checking in Windows-specific results?

Jia Pu

Comment 5 2010-10-07 09:37:27 PDT

(In reply to comment #4) > (In reply to comment #3) > > Sorry for not catching this earlier. Adam is right - these tests should be moved to platform/mac > > I guess that means you think that is a better option than checking in Windows-specific results? The new autocorrection, which is part of AppKit, is only available on Mac. I guess we should just make those tests Mac only.

Jia Pu

Comment 6 2010-10-07 13:00:17 PDT

Created attachment 70138 [details] Proposed patch (v1)

Adele Peterson

Comment 7 2010-10-07 15:22:04 PDT

Comment on attachment 70138 [details] Proposed patch (v1) This skipped lists need to be updated for the new test locations.

WebKit Commit Bot

Comment 8 2010-10-07 15:29:08 PDT

Comment on attachment 70138 [details] Proposed patch (v1) Rejecting patch 70138 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: contained 'editing/spelling/autocorrection-removing-underline.html', but no file of that name could be found Skipped list contained 'editing/spelling/autocorrection-simple.html', but no file of that name could be found Testing 21488 test cases. platform/mac/editing/spelling/autocorrection-delete.html -> failed Exiting early after 1 failures. 17836 tests run. 313.90s total testing time 17835 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 31 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4190136

Jia Pu

Comment 9 2010-10-07 15:48:42 PDT

Created attachment 70161 [details] Proposed patch (v1) Modified Skipped files to reflect the new location of tests.

Adele Peterson

Comment 10 2010-10-07 15:51:05 PDT

Comment on attachment 70161 [details] Proposed patch (v1) Brian's going to land this manually.

Brian Weinstein

Comment 11 2010-10-07 16:32:49 PDT

Landed in r69351.

Note You need to log in before you can comment on or make changes to this bug.