Bug 47303

Summary:

Convert layoutInlineChildren to be block-flow-aware.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

46123

Attachments:

Description	Flags
Patch	mitz: review+

Description Dave Hyatt 2010-10-06 14:16:50 PDT

Convert layoutInlineChildren to be block-flow-aware.  None of the functions it calls are patched yet.

Comment 1 Dave Hyatt 2010-10-06 14:17:42 PDT

Created attachment 69989 [details]
Patch

Comment 2 mitz 2010-10-06 14:29:56 PDT

Comment on attachment 69989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69989&action=review

> WebCore/rendering/RenderBlockLineLayout.cpp:510
> +    int toAdd = borderAfter() + paddingAfter() + scrollbarLogicalHeight();

Need toRename this variable someday.

Comment 3 Dave Hyatt 2010-10-06 14:44:35 PDT

Fixed in r69235.