Bug 47291

Summary: [Mac] [DRT] implement setSpatialNavigationEnabled
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46905    
Attachments:
Description Flags
(committed r69373, r=smfr) patch v1 none

Antonio Gomes
Reported 2010-10-06 12:14:16 PDT
It would make possible to the current spatial navigation 20 layout tests to run on Mac. They currently run on Gtk and Qt only.
Attachments
(committed r69373, r=smfr) patch v1 (11.72 KB, patch)
2010-10-07 07:18 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-10-07 07:18:39 PDT
Created attachment 70082 [details] (committed r69373, r=smfr) patch v1 Implement setSpatialNavigationEnabled to Mac's DRT. It also required additions to WebPreferencesPrivate and WebView in WebKit/Mac side.
Antonio Gomes
Comment 2 2010-10-07 08:35:05 PDT
Simon, we need a Mac guy here. Mind to have a review?
Simon Fraser (smfr)
Comment 3 2010-10-07 08:54:06 PDT
Comment on attachment 70082 [details] (committed r69373, r=smfr) patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review > LayoutTests/platform/mac/Skipped:331 > +# Spatial Navigation: test can be affected by font metric differences. > +fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html > +fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html This is unfortunate. Can the tests be rewritten to avoid this? > WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222 > + // Has mac implementation. This comment seems redundant.
Antonio Gomes
Comment 4 2010-10-07 09:22:57 PDT
(In reply to comment #3) > (From update of attachment 70082 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70082&action=review > > > LayoutTests/platform/mac/Skipped:331 > > +# Spatial Navigation: test can be affected by font metric differences. > > +fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html > > +fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html > > This is unfortunate. Can the tests be rewritten to avoid this? I am going to do this in a follow up, yes. It has some high priority on my list. I am right now thinking of a smart way we could avoid stuff like this ... > > WebKitTools/DumpRenderTree/LayoutTestController.cpp:1222 > > + // Has mac implementation. > > This comment seems redundant. Many other methods have this, Simon. Ones even have "Has Mac and windows implementation".
Antonio Gomes
Comment 5 2010-10-07 20:57:14 PDT
Comment on attachment 70082 [details] (committed r69373, r=smfr) patch v1 Clearing flags on attachment: 70082. Committed r69373: <http://trac.webkit.org/changeset/69373>
WebKit Review Bot
Comment 6 2010-10-07 21:58:00 PDT
http://trac.webkit.org/changeset/69373 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.