Bug 47284

Summary: [Qt] Correct CamelCase of socketSentdata() in SocketStreamHandle
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: WebCore Misc.Assignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, kenneth, markus, ossy
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
Patch none

Andras Becsi
Reported 2010-10-06 11:14:02 PDT
Plenty of layout tests have "QMetaObject::invokeMethod: No such method WebCore::SocketStreamHandlePrivate::socketSentData()" messages in stderr in WebKit2. Correct the CamelCase of the socketSentdata() method to fix these warnings in layout tests.
Attachments
proposed patch (1.84 KB, patch)
2010-10-06 11:17 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Patch (2.18 KB, text/plain)
2010-10-06 12:55 PDT, Vincent Scheib 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2010-10-06 11:17:47 PDT
Created attachment 69964 [details] proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-10-06 11:21:17 PDT
Comment on attachment 69964 [details] proposed patch Looks fine. Are you certain that socketSentdata() is not called from anywhere today?
Andras Becsi
Comment 3 2010-10-06 11:27:59 PDT
(In reply to comment #2) > (From update of attachment 69964 [details]) > Looks fine. Are you certain that socketSentdata() is not called from anywhere today? I grepped the whole source, and it isn't used anywhere else. It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled.
Andras Becsi
Comment 4 2010-10-06 11:28:57 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 69964 [details] [details]) > > Looks fine. Are you certain that socketSentdata() is not called from anywhere today? > > I grepped the whole source, and it isn't used anywhere else. > It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled. ./WebCore/platform/network/qt/SocketStreamHandleQt.cpp:103: QMetaObject::invokeMethod(this, "socketSentData", Qt::QueuedConnection);
WebKit Commit Bot
Comment 5 2010-10-06 12:16:13 PDT
Comment on attachment 69964 [details] proposed patch Clearing flags on attachment: 69964 Committed r69221: <http://trac.webkit.org/changeset/69221>
WebKit Commit Bot
Comment 6 2010-10-06 12:16:18 PDT
All reviewed patches have been landed. Closing bug.
Vincent Scheib
Comment 7 2010-10-06 12:55:33 PDT
Created attachment 69978 [details] Patch
Vincent Scheib
Comment 8 2010-10-06 12:57:31 PDT
Comment on attachment 69978 [details] Patch Sorry for spam on this bug - not certain how I typo-ed the bug number.
Note You need to log in before you can comment on or make changes to this bug.