Bug 47250

Summary:

Web Inspector: test that uncaught exceptions have stack trace when inspector is open

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
[PATCH] General Expected Results	mitz: review+

Yury Semikhatsky

Reported 2010-10-06 02:17:08 PDT

Web Inspector: test that uncaught exceptions have stack trace when inspector is open

Attachments
Patch (4.84 KB, patch) 2010-10-06 02:45 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
[PATCH] General Expected Results (1.12 KB, patch) 2010-10-08 22:22 PDT, Joseph Pecoraro	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2010-10-06 02:45:09 PDT

Created attachment 69909 [details] Patch

Yury Semikhatsky

Comment 2 2010-10-06 06:42:29 PDT

Comment on attachment 69909 [details] Patch Clearing flags on attachment: 69909 Committed r69190: <http://trac.webkit.org/changeset/69190>

Yury Semikhatsky

Comment 3 2010-10-06 06:42:39 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 4 2010-10-06 09:39:46 PDT

Comment on attachment 69909 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69909&action=review > LayoutTests/http/tests/inspector/console-tests2.js:29 > \ No newline at end of file Nit: Newline! If you remember next time you update the file =). Nice test.

Adam Barth

Comment 5 2010-10-08 14:59:10 PDT

This patch does not have expected results on non-Chromium ports: http://trac.webkit.org/changeset/69190 Can you please add some? kthxsbye

Joseph Pecoraro

Comment 6 2010-10-08 20:14:44 PDT

I'm still updating (and would have to build) before I could verify. But the snow leopard bots produced the following results: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r69440%20(19029)/inspector/console-uncaught-exception-actual.txt I'm guessing the differences are jsc/v8 related.

Joseph Pecoraro

Comment 7 2010-10-08 22:22:47 PDT

Created attachment 70342 [details] [PATCH] General Expected Results Looks like git was smarter than me. I ran and generated the expected results on my snow leopard machine. I checked and noticed gtk's results (added since this landed) were identical and removed them. Git considers it just a file move. That works for me.

Joseph Pecoraro

Comment 8 2010-10-08 22:23:43 PDT

I don't have a windows machine to test on, but I assume it should work fine with these results. There aren't any windows platform specific results for inspector tests.

Joseph Pecoraro

Comment 9 2010-10-08 22:35:13 PDT

Committed r69441 D LayoutTests/platform/gtk/inspector/console-uncaught-exception-expected.txt A LayoutTests/inspector/console-uncaught-exception-expected.txt M LayoutTests/ChangeLog r69441 = 4bf3c909c6f049dc3bf507926d7b11a66f58b386 http://trac.webkit.org/changeset/69441

Joseph Pecoraro

Comment 10 2010-12-20 15:05:22 PST

Comment on attachment 70342 [details] [PATCH] General Expected Results Removed the cq? flag, since this landed a while ago.

Note You need to log in before you can comment on or make changes to this bug.