Bug 47195

Summary: [Qt] Duplicated code in QWebPagePrivate
Product: WebKit Reporter: Ragner Magalhaes <ragner.magalhaes>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch 01 none

Ragner Magalhaes
Reported 2010-10-05 10:34:16 PDT
In QWebPagePrivate class has some duplicated methods for mouse events from QGraphicsView and QWidget.
Attachments
Patch 01 (13.83 KB, patch)
2010-10-05 11:35 PDT, Ragner Magalhaes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ragner Magalhaes
Comment 1 2010-10-05 11:35:21 PDT
Created attachment 69817 [details] Patch 01
Antonio Gomes
Comment 2 2010-10-05 11:38:26 PDT
Comment on attachment 69817 [details] Patch 01 This is a great thing! r=me, but please wait kling, simon or kenneth to look at it, and set cq+
Ragner Magalhaes
Comment 3 2010-10-05 11:41:30 PDT
(In reply to comment #2) > (From update of attachment 69817 [details]) > This is a great thing! r=me, but please wait kling, simon or kenneth to look at it, and set cq+ Ok, waiting :P
Andreas Kling
Comment 4 2010-10-05 11:42:41 PDT
I like it.
WebKit Commit Bot
Comment 5 2010-10-06 11:53:49 PDT
Comment on attachment 69817 [details] Patch 01 Clearing flags on attachment: 69817 Committed r69217: <http://trac.webkit.org/changeset/69217>
WebKit Commit Bot
Comment 6 2010-10-06 11:53:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.