Summary: | [chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vincent Scheib <scheib> | ||||||
Component: | New Bugs | Assignee: | Vincent Scheib <scheib> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, kbr, vangelis | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Vincent Scheib
2010-10-05 10:28:34 PDT
Created attachment 69806 [details]
Patch
Comment on attachment 69806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69806&action=review I think an inline comment about blending would help us remember why it's done the way it is. Otherwise looks good! > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:206 > + GLC(m_context, m_context->disable(GraphicsContext3D::BLEND)); Can you please add a comment here saying that we need to render the root layer without blending to get subpixel antialised text displaying correctly? That way we won't forget why we need to flip blending on and off. Created attachment 69818 [details]
Patch
Comment on attachment 69818 [details]
Patch
Looks fine to me; confirmed with Vincent offline that CSS 3D tests with translucent layers continue to render correctly.
Comment on attachment 69818 [details] Patch Clearing flags on attachment: 69818 Committed r69144: <http://trac.webkit.org/changeset/69144> All reviewed patches have been landed. Closing bug. |