Bug 47189 – Ignore whitespace in base64 decoding of data URL

• Component: Platform
• Status: RESOLVED DUPLICATE

[Kwang Yul Seo]

RFC2397 (The "data" URL scheme) refers to RFC 2045 (MIME) for base64 decoding and RFC 2045 states: All line breaks or other characters not found in Table 1 must be ignored by decoding software. Acid3 test 97 tests this.

Pass IgnoreWhitespace to base64Decode function to ignore whitespace in base64 decoding.

[Kwang Yul Seo]

Created attachment 69803 [details]
Patch

[Kwang Yul Seo]

CC'ing Alp Toker for review.

[Darin Adler]

Comment on attachment 69803 [details]
Patch

This helps only the CURL port. We want to move data URL handling out of ResourceHandle entirely and share it between all platforms.

[WebKit Commit Bot]

Comment on attachment 69803 [details]
Patch

Rejecting patch 69803 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69803]" exit_code: 2
Cleaning working directory
Updating working directory
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=69803&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=47189&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 69803 from bug 47189.
Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/4221115

[Kwang Yul Seo]

(In reply to comment #3)
> (From update of attachment 69803 [details])
> This helps only the CURL port. We want to move data URL handling out of ResourceHandle entirely and share it between all platforms.

Yes, I agree. Brew MP http backend (not yet upstreamed) also copied data URL code from the CURL port.

[Kwang Yul Seo]

Done in bug 41462

*** This bug has been marked as a duplicate of bug 41462 ***