Bug 47180

Summary: SVGTextLayoutAttributesBuilder: "XValue" and "YValue" clash with X11 macros
Product: WebKit Reporter: Andreas Kling <kling>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, zimmermann
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2010-10-05 08:25:12 PDT
Xutil.h defines both "XValue" and "YValue", so including that before SVGTextLayoutAttributesBuilder.h breaks compilation. It would be neat if we could avoid these names (but there's always the npruntime_internal.h approach of manually undeffing things..) This currently breaks Qt+V8 compilation.
Attachments
Proposed patch (3.79 KB, patch)
2010-10-08 02:43 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-10-08 02:36:27 PDT
Ok, just rename to XValueAttribute or sth. similar, no problem.
Andreas Kling
Comment 2 2010-10-08 02:43:02 PDT
Created attachment 70217 [details] Proposed patch
Nikolas Zimmermann
Comment 3 2010-10-08 02:45:57 PDT
Comment on attachment 70217 [details] Proposed patch r=me.
Andreas Kling
Comment 4 2010-10-08 07:36:40 PDT
Comment on attachment 70217 [details] Proposed patch Clearing flags on attachment: 70217 Committed r69399: <http://trac.webkit.org/changeset/69399>
Andreas Kling
Comment 5 2010-10-08 07:36:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.