Bug 47179

Summary: Don't include JavaScriptCore/config.h from command line
Product: WebKit Reporter: Kristian Monsen <kristianm>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Proposed patch none

Kristian Monsen
Reported 2010-10-05 08:11:17 PDT
JavaScriptCore/config.h were included from WebCorePrefix.h. This is included on the command line, which means it is included before any content in a cpp file. It also violates the rules in WebCorePrefix.h Moving the include to WebCore/config.h, so if one is included both will be.
Attachments
Proposed patch (1.88 KB, patch)
2010-10-05 08:14 PDT, Kristian Monsen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kristian Monsen
Comment 1 2010-10-05 08:14:14 PDT
Created attachment 69784 [details] Proposed patch
Steve Block
Comment 2 2010-10-05 08:22:35 PDT
Comment on attachment 69784 [details] Proposed patch r=me
WebKit Commit Bot
Comment 3 2010-10-05 08:53:55 PDT
Comment on attachment 69784 [details] Proposed patch Clearing flags on attachment: 69784 Committed r69112: <http://trac.webkit.org/changeset/69112>
WebKit Commit Bot
Comment 4 2010-10-05 08:54:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.