Bug 47168

Summary: [Qt] WebKit2 should support focusing
Product: WebKit Reporter: Kimmo Kinnunen <kimmo.t.kinnunen>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch to set focus and active flags when qgraphicswkitem gets focused. none

Description Kimmo Kinnunen 2010-10-05 04:35:42 PDT 
Qt WebKit2 API should support setting and unsetting focus for the QGraphicsWKView. Otherwise input/text areas don't display caret.
Comment 1 Kimmo Kinnunen 2010-10-05 07:21:10 PDT 
Created attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.
Comment 2 Andreas Kling 2010-10-06 22:56:40 PDT 
Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

LGTM.
Comment 3 WebKit Commit Bot 2010-10-06 23:26:05 PDT 
Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

Rejecting patch 69781 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2
Last 500 characters of output:
l tests successful.
Files=14, Tests=304,  1 wallclock secs ( 0.72 cusr +  0.17 csys =  0.89 CPU)
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Projects/CommitQueue/LayoutTests
Testing 21469 test cases.
java/lc3/JSObject/ToObject-001.html -> failed

Exiting early after 1 failures. 17533 tests run.
282.75s total testing time

17532 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
28 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4255039
Comment 4 Kimmo Kinnunen 2010-10-08 00:25:56 PDT 
Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

can somebody re-cq+ ? I think the cq failure was unrelated to this patch.
Comment 5 Andreas Kling 2010-10-08 03:30:44 PDT 
Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

Let's try that again.
Comment 6 WebKit Commit Bot 2010-10-08 04:42:42 PDT 
Comment on attachment 69781 [details]
Patch to set focus and active flags when qgraphicswkitem gets focused.

Clearing flags on attachment: 69781

Committed r69391: <http://trac.webkit.org/changeset/69391>
Comment 7 WebKit Commit Bot 2010-10-08 04:42:47 PDT 
All reviewed patches have been landed.  Closing bug.