| Summary: | Add MIMEType accessor to WKFrame | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2010-10-04 19:09:11 PDT
Created attachment 69730 [details]
Patch
Attachment 69730 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 6 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 69730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69730&action=review > WebKit2/WebKit2.xcodeproj/project.pbxproj:1990 > + developmentRegion = English; Please don’t land this. You’re not otherwise modifying this project file. r=me |