Bug 47135

Summary:

Implement ApplicationCacheHost::stopLoadingInFrame(Frame*) for Chromium

Product:

WebKit

Reporter:

Hin-Chung Lam <hclam>

Component:

New Bugs

Assignee:

Michael Nordman <michaeln>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

michaeln

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
cleanup	none

Hin-Chung Lam

Reported 2010-10-04 17:26:20 PDT

WebKit r69041 added this new method. Since we have a separate implementation of the file we need to implement it correctly.

Attachments
cleanup (3.42 KB, patch) 2011-03-01 18:55 PST, Michael Nordman	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Nordman

Comment 1 2010-10-05 13:52:35 PDT

I see, we just need an empty impl of the new method... void ApplicatinCacheHost::stopLoadingInFrame(Frame*) { // N/A to the chromium port which doesn't use webcore's loader. } So the build fix is the real fix (modulo the comment).

Michael Nordman

Comment 2 2011-03-01 18:55:21 PST

Created attachment 84355 [details] cleanup

Michael Nordman

Comment 3 2011-03-02 12:06:02 PST

Comment on attachment 84355 [details] cleanup nm... i'll just commit these unreviewed

Michael Nordman

Comment 4 2011-03-15 16:15:23 PDT

the code comment has been changed

Note You need to log in before you can comment on or make changes to this bug.