Bug 47130 – [chromium] Get the link from a plugin when creating a context menu

• Component: New Bugs
• Status: RESOLVED FIXED

[John Abd-El-Malek]

[chromium] Get the link from a plugin when creating a context menu

[John Abd-El-Malek]

Created attachment 69714 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 69714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69714&action=review

> WebKit/chromium/public/WebPlugin.h:104
> +    virtual WebURL absoluteURL(const WebPoint& position) const { return WebURL(); }

hmm... the name of this method could use some improvements.  something like
absoluteURLAtPosition would be better, but even that is fairly awkward and
not as self-documenting as it ought to be.

maybe using the word "link" would help or even "href"...  hmm, I'll think on
this.

[Darin Fisher (:fishd, Google)]

Could this API also be used to show a status message when the user hovers over a link?

WebPlugin::{href,link}AtPosition

[John Abd-El-Malek]

(In reply to comment #3)
> Could this API also be used to show a status message when the user hovers over a link?

ah yes, good suggestion.

> 
> WebPlugin::{href,link}AtPosition

linkAtPosition sounds good

[John Abd-El-Malek]

Created attachment 69830 [details]
Patch

[John Abd-El-Malek]

Committed r69154: <http://trac.webkit.org/changeset/69154>