Bug 47113 – Move SharedGraphicsContext3D from ChromeClient to Page

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Chris Marrin]

In talking to James Robinson, we've agreed that SharedGraphicsContext3D doesn't need to be in ChromeClient. Page has the same lifetime and there are no platform dependencies in this class.

[Chris Marrin]

Created attachment 69681 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 69681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69681&action=review

> WebCore/page/Page.cpp:783
> +        if (!context)
> +            return 0;
> +        m_sharedGraphicsContext3D = SharedGraphicsContext3D::create(context.release());
> +    }

I think the GraphicsContext3D::create() stuff should be hidden inside of 
static bool SharedGraphicsContext3D::canCreateContext() or something, or maybe SharedGraphicsContext3D::create() should just return 0 if the context can't be created.

[Chris Marrin]

Created attachment 69695 [details]
Patch

[James Robinson]

Comment on attachment 69695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69695&action=review

Looks fine to me.

> WebCore/page/Page.cpp:69
> +#if ENABLE(ACCELERATED_2D_CANVAS)
> +#include "SharedGraphicsContext3D.h"
> +#endif

Normally conditionally included headers are put after the main list of headers, not in the middle.

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/69053