Summary: | Move SharedGraphicsContext3D from ChromeClient to Page | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Marrin <cmarrin> | ||||||
Component: | Layout and Rendering | Assignee: | Chris Marrin <cmarrin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jamesr, kbr, senorblanco, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Chris Marrin
2010-10-04 14:12:22 PDT
Created attachment 69681 [details]
Patch
Comment on attachment 69681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69681&action=review > WebCore/page/Page.cpp:783 > + if (!context) > + return 0; > + m_sharedGraphicsContext3D = SharedGraphicsContext3D::create(context.release()); > + } I think the GraphicsContext3D::create() stuff should be hidden inside of static bool SharedGraphicsContext3D::canCreateContext() or something, or maybe SharedGraphicsContext3D::create() should just return 0 if the context can't be created. Created attachment 69695 [details]
Patch
Comment on attachment 69695 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69695&action=review Looks fine to me. > WebCore/page/Page.cpp:69 > +#if ENABLE(ACCELERATED_2D_CANVAS) > +#include "SharedGraphicsContext3D.h" > +#endif Normally conditionally included headers are put after the main list of headers, not in the middle. Landed in http://trac.webkit.org/changeset/69053 |