Bug 47112

Summary:

Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

46123

Attachments:

Description	Flags
Patch	mitz: review+

Description Dave Hyatt 2010-10-04 14:03:41 PDT

Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware.  Also clean up how floats are placed to use a bit instead of the magic -1 value on top().

Comment 1 Dave Hyatt 2010-10-04 14:49:09 PDT

Created attachment 69688 [details]
Patch

Comment 2 mitz 2010-10-04 15:08:19 PDT

Comment on attachment 69688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69688&action=review

> WebCore/rendering/RenderBlock.h:393
>          int left() const { return m_frameRect.x(); }
>          int right() const { return m_frameRect.right(); }
>          int top() const { return m_frameRect.y(); }

Should these accessors ASSERT(m_isPlaced)?

Comment 3 Dave Hyatt 2010-10-04 23:14:22 PDT

Fixed in r69082.  The asserts caught some badness, so there's some additional code.

Comment 4 WebKit Review Bot 2010-10-04 23:24:54 PDT

http://trac.webkit.org/changeset/69082 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release