| Summary: | Patch the floatBottom function and its friends. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mitz | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 46643 | ||||||
| Attachments: |
|
||||||
|
Description
Dave Hyatt
2010-10-01 15:15:19 PDT
Created attachment 69526 [details]
Patch
Comment on attachment 69526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69526&action=review > WebCore/rendering/RenderBlock.cpp:3296 > -int > -RenderBlock::floatBottom() const > +int RenderBlock::lowestFloatLogicalBottom(FloatingObject::Type floatType) const Finally! > WebCore/rendering/RenderBlock.cpp:3304 > + if (r->type() & floatType) Kind of ugly. I’d like at least to see a comment about the definition of the FloatingObject::Type enum saying that it’s a bitfield. (In reply to comment #2) > I’d like at least to see a comment about the definition of the FloatingObject::Type enum saying that it’s a bitfield. s/about/above/ |