Bug 47017

Summary:

REGRESSION (r63957): fast/text/backslash-to-yen-sign-euc.html fails on Mac

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, eric, hamaji, mitz, tkent, webkit.review.bot

Priority:

Keywords:

InRadar, LayoutTestFailure, Regression

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none
Patch v2	ap: review+, ap: commit-queue-

Adam Roben (:aroben)

Reported 2010-10-01 14:07:23 PDT

http://trac.webkit.org/changeset/63957 updated the Mac results for fast/text/backslash-to-yen-sign-euc.html, introducing many failures. You can now see lots of examples of "expected: backslash, actual: \x{A5}" in the test.

Attachments
Patch v1 (11.58 KB, patch) 2010-10-11 00:49 PDT, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Patch v2 (168.72 KB, patch) 2010-10-11 10:15 PDT, Shinichiro Hamaji	ap: review+ ap: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2010-10-01 14:08:33 PDT

<rdar://problem/8504199>

Shinichiro Hamaji

Comment 2 2010-10-11 00:49:20 PDT

Created attachment 70427 [details] Patch v1

Shinichiro Hamaji

Comment 3 2010-10-11 00:55:17 PDT

Sorry, I should have updated the description of the test cases. We changed the behavior of how fonts in control element are considered. So, these changes are intended (actually, I thought I changed the descriptions... Maybe I've made some mistakes). This change won't change the expectations of Windows, Qt, Gtk, and Chromium. I'll fix them soon after I'll land this patch.

Alexey Proskuryakov

Comment 4 2010-10-11 08:48:54 PDT

The patch doesn't include updated pixel results.

Shinichiro Hamaji

Comment 5 2010-10-11 10:15:38 PDT

Created attachment 70442 [details] Patch v2

Shinichiro Hamaji

Comment 6 2010-10-11 10:16:04 PDT

(In reply to comment #4) > The patch doesn't include updated pixel results. Oops. Updated.

Alexey Proskuryakov

Comment 7 2010-10-11 10:20:37 PDT

Comment on attachment 70442 [details] Patch v2 OK. Please update the ChangeLog to list pixel results, too.

Shinichiro Hamaji

Comment 8 2010-10-12 01:01:06 PDT

Committed r69564: <http://trac.webkit.org/changeset/69564>

WebKit Review Bot

Comment 9 2010-10-12 01:34:12 PDT

http://trac.webkit.org/changeset/69564 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.