Bug 46992

Summary: Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: WebKit2Assignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2010-10-01 09:57:28 PDT
Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
Comment 1 Anders Carlsson 2010-10-01 09:59:39 PDT
Created attachment 69477 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-01 10:02:18 PDT
Attachment 69477 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:698:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:726:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-10-01 10:03:03 PDT
<rdar://problem/8502700>
Comment 4 mitz 2010-10-01 10:39:43 PDT
Comment on attachment 69477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69477&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:80
> +    String proxiesForURL(const String& urlString);
> +    String cookiesForURL(const String& urlString);

No need to name the argument in these two.

> WebKit2/WebProcess/Plugins/PluginController.h:96
> +    virtual String proxiesForURL(const String& urlString) = 0;
> +
> +    // Returns the cookies for the given URL or null on failure.
> +    virtual String cookiesForURL(const String& urlString) = 0;
> +

No need to name the arguments in these two.

> WebKit2/WebProcess/Plugins/PluginView.h:131
> +    virtual String proxiesForURL(const String& urlString);
> +    virtual String cookiesForURL(const String& urlString);

No need to name the arguments here.
Comment 5 Anders Carlsson 2010-10-01 10:46:48 PDT
Committed r68898: <http://trac.webkit.org/changeset/68898>