Summary: | Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, eric, gustavo, mdelaney7, webkit-ews, webkit.review.bot, xan.lopez, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 45532 | ||||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-10-01 00:41:37 PDT
Created attachment 69431 [details]
Patch
Attachment 69431 [details] did not build on gtk: Build output: http://queues.webkit.org/results/4165037 Attachment 69431 [details] did not build on mac: Build output: http://queues.webkit.org/results/4143037 Attachment 69431 [details] did not build on qt: Build output: http://queues.webkit.org/results/4193037 Attachment 69431 [details] did not build on chromium: Build output: http://queues.webkit.org/results/4192039 Created attachment 69432 [details]
Patch v2
Renamed SVGTextChunk to SVGTextChunkNew, to avoid clashes with the SVGTextChunk class that still lives in SVGTextChunkLayoutInfo.h (which will be removed alltogether, once the new engine lands);
Attachment 69432 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/rendering/svg/SVGTextChunk.cpp:47: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 69432 [details] did not build on mac: Build output: http://queues.webkit.org/results/4170047 Created attachment 69434 [details]
Patch v3
Fix style issue, mac build problem and write a much more explicit ChangeLog, as requested by Dirk.
Comment on attachment 69434 [details]
Patch v3
LGTM. We already discussed some changes on IRC (can be seen by comparing the different patches). Niko has the next patch ready, that moves some files, so that we can fix the FIXMEs. r=me
Landed in r68873. |