Summary: | Add helper methods to cast between renderers & SVGTextContent/PositioningElement | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mdelaney7, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-10-01 00:02:18 PDT
Created attachment 69428 [details]
Patch
Comment on attachment 69428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69428&action=review The patch itself looks good to me. r=me with the fixes. > WebCore/svg/SVGTextContentElement.cpp:219 > +SVGTextContentElement* SVGTextContentElement::fromRenderer(RenderObject* renderer) Another name for 'fromRenderer' is maybe more self-explanatory. Niko suggested elementFromRenderer. > WebCore/svg/SVGTextContentElement.cpp:238 > + if (!node->hasTagName(SVGNames::textTag) > + && !node->hasTagName(SVGNames::tspanTag) > +#if ENABLE(SVG_FONTS) > + && !node->hasTagName(SVGNames::altGlyphTag) > +#endif > + && !node->hasTagName(SVGNames::trefTag) > + && !node->hasTagName(SVGNames::textPathTag)) > + return 0; The indention is wrong. > WebCore/svg/SVGTextPositioningElement.cpp:164 > + if (!node->hasTagName(SVGNames::textTag) > + && !node->hasTagName(SVGNames::tspanTag) > +#if ENABLE(SVG_FONTS) > + && !node->hasTagName(SVGNames::altGlyphTag) > +#endif > + && !node->hasTagName(SVGNames::trefTag)) > + return 0; wrong indention. |