Bug 46913

Summary: REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: AccessibilityAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, jhoneycutt, simon.fraser, webkit.review.bot, zimmermann
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/results/Windows%20Release%20(Tests)/r68785%20(4613)/CrashLog_0404_2010-09-30_09-33-26-342.txt
Attachments:
Description Flags
Patch for this and bug 46914.
none
Patch jhoneycutt: review+

Adam Roben (:aroben)
Reported 2010-09-30 09:50:48 PDT
The buildbots are crashing when running platform/win/accessibility/selection-and-focus.html. Looks like a null-dereference. See the URL for the crash log.
Attachments
Patch for this and bug 46914. (4.31 KB, patch)
2010-09-30 16:37 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2010-09-30 16:52 PDT, Simon Fraser (smfr) 		jhoneycutt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-09-30 09:51:42 PDT
<rdar://problem/8497332>
Adam Roben (:aroben)
Comment 2 2010-09-30 09:56:39 PDT
webkit-patch failure-reason blames http://trac.webkit.org/changeset/65681
Simon Fraser (smfr)
Comment 3 2010-09-30 15:45:21 PDT
For some reason, accessibilityController.focusedElement.childAtIndex(0).takeFocus(); is now focussing the anonymous block that is the select's parent.
Simon Fraser (smfr)
Comment 4 2010-09-30 16:10:07 PDT
I think the test is incorrect. I don't know how it passed before.
Simon Fraser (smfr)
Comment 5 2010-09-30 16:37:39 PDT
Created attachment 69392 [details] Patch for this and bug 46914.
WebKit Review Bot
Comment 6 2010-09-30 16:43:17 PDT
Attachment 69392 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 7 2010-09-30 16:52:51 PDT
Created attachment 69396 [details] Patch
Jon Honeycutt
Comment 8 2010-09-30 16:59:43 PDT
Comment on attachment 69396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69396&action=review > LayoutTests/platform/win/accessibility/selection-and-focus.html:42 > + Reduce whitespace! Save the whitespace trees!
Simon Fraser (smfr)
Comment 9 2010-09-30 17:40:09 PDT
http://trac.webkit.org/changeset/68855
Note You need to log in before you can comment on or make changes to this bug.