Bug 46906

Summary: Rename get* and open*Cursor per the spec on IDBIndex
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
Patch japhet: review+

Description Jeremy Orlow 2010-09-30 08:49:42 PDT 
The spec changed so that:
IDBIndex.get -> getKey
IDBIndex.getObject -> get
IDBIndex.openCursor -> openKeyCursor
IDBIndex.openObjectCursor -> openCursor
Comment 1 Jeremy Orlow 2010-09-30 08:51:56 PDT 
Created attachment 69339 [details]
patch
Comment 2 Andrei Popescu 2010-09-30 09:33:33 PDT 
LGTM
Comment 3 Steve Block 2010-10-01 09:11:10 PDT 
Comment on attachment 69339 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69339&action=review

> WebCore/ChangeLog:13
> +

Should mention the tests that cover this

> WebKit/chromium/public/WebIDBIndex.h:68
> +        openKeyCursor(range, direction, callbacks, transaction);

Should we call openObjectCursor()?

> WebKit/chromium/public/WebIDBIndex.h:77
> +        getKey(range, callbacks, transaction);

Shouldn't we call getObject()?
Comment 4 Jeremy Orlow 2010-10-04 13:37:47 PDT 
(In reply to comment #3)
> (From update of attachment 69339 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69339&action=review
> 
> > WebCore/ChangeLog:13
> > +
> 
> Should mention the tests that cover this

Will do.
 
> > WebKit/chromium/public/WebIDBIndex.h:68
> > +        openKeyCursor(range, direction, callbacks, transaction);
> 
> Should we call openObjectCursor()?
> 
> > WebKit/chromium/public/WebIDBIndex.h:77
> > +        getKey(range, callbacks, transaction);
> 
> Shouldn't we call getObject()?

Nope..this is temp code to get around webkit roll issues.  What currently (in chromium) is ___ should be ___Key
Comment 5 Jeremy Orlow 2010-10-04 14:38:17 PDT 
Created attachment 69684 [details]
Patch
Comment 6 Jeremy Orlow 2010-10-05 10:17:54 PDT 
Committed r69123: <http://trac.webkit.org/changeset/69123>