Bug 46906 – Rename get* and open*Cursor per the spec on IDBIndex

• Component: New Bugs
• Status: RESOLVED FIXED

[Jeremy Orlow]

The spec changed so that:
IDBIndex.get -> getKey
IDBIndex.getObject -> get
IDBIndex.openCursor -> openKeyCursor
IDBIndex.openObjectCursor -> openCursor

[Jeremy Orlow]

Created attachment 69339 [details]
patch

[Andrei Popescu]

LGTM

[Steve Block]

Comment on attachment 69339 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=69339&action=review

> WebCore/ChangeLog:13
> +

Should mention the tests that cover this

> WebKit/chromium/public/WebIDBIndex.h:68
> +        openKeyCursor(range, direction, callbacks, transaction);

Should we call openObjectCursor()?

> WebKit/chromium/public/WebIDBIndex.h:77
> +        getKey(range, callbacks, transaction);

Shouldn't we call getObject()?

[Jeremy Orlow]

(In reply to comment #3)
> (From update of attachment 69339 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69339&action=review
> 
> > WebCore/ChangeLog:13
> > +
> 
> Should mention the tests that cover this

Will do.
 
> > WebKit/chromium/public/WebIDBIndex.h:68
> > +        openKeyCursor(range, direction, callbacks, transaction);
> 
> Should we call openObjectCursor()?
> 
> > WebKit/chromium/public/WebIDBIndex.h:77
> > +        getKey(range, callbacks, transaction);
> 
> Shouldn't we call getObject()?

Nope..this is temp code to get around webkit roll issues.  What currently (in chromium) is ___ should be ___Key

[Jeremy Orlow]

Created attachment 69684 [details]
Patch

[Jeremy Orlow]

Committed r69123: <http://trac.webkit.org/changeset/69123>