Bug 46891

Summary: Many tests in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/builders/Windows%20Debug%20%28Tests%29/builds/20495/steps/webkitpy-test/logs/stdio
Attachments:
Description Flags
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work abarth: review+

Adam Roben (:aroben)
Reported 2010-09-30 06:11:16 PDT
See URL for failures like this: ERROR: test_handled_error (webkitpy.tool.bot.queueengine_unittest.QueueEngineTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/buildbot/slave/win-debug-tests/build/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py", line 207, in tearDown shutil.rmtree(self.temp_dir) File "/usr/lib/python2.5/shutil.py", line 178, in rmtree onerror(os.rmdir, path, sys.exc_info()) File "/usr/lib/python2.5/shutil.py", line 176, in rmtree os.rmdir(path) OSError: [Errno 90] Directory not empty: '/cygdrive/c/DOCUME~1/buildbot/LOCALS~1/Temp/tmpWpOrjbwork_queue_test_logs'
Attachments
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work (5.58 KB, patch)
2010-09-30 06:21 PDT, Adam Roben (:aroben) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-09-30 06:13:23 PDT
<rdar://problem/8496638>
Adam Roben (:aroben)
Comment 2 2010-09-30 06:21:38 PDT
Created attachment 69329 [details] Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work
WebKit Review Bot
Comment 3 2010-09-30 06:23:13 PDT
Attachment 69329 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57: whitespace before ']' [pep8/E202] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 4 2010-09-30 09:18:47 PDT
Comment on attachment 69329 [details] Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work View in context: https://bugs.webkit.org/attachment.cgi?id=69329&action=review thanks! > WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57 > + 'stop_work_queue' The style bot wants you to put a , after this line.
Adam Roben (:aroben)
Comment 5 2010-09-30 09:41:47 PDT
Committed r68793: <http://trac.webkit.org/changeset/68793>
Note You need to log in before you can comment on or make changes to this bug.