Summary: | Many tests in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | http://build.webkit.org/builders/Windows%20Debug%20%28Tests%29/builds/20495/steps/webkitpy-test/logs/stdio | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-09-30 06:11:16 PDT
Created attachment 69329 [details]
Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work
Attachment 69329 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57: whitespace before ']' [pep8/E202] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 69329 [details] Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work View in context: https://bugs.webkit.org/attachment.cgi?id=69329&action=review thanks! > WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:57 > + 'stop_work_queue' The style bot wants you to put a , after this line. Committed r68793: <http://trac.webkit.org/changeset/68793> |