Summary: | [chromium] add an identifier method to WebFrame | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jochen | ||||||
Component: | New Bugs | Assignee: | jochen | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, fishd | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
jochen
2010-09-30 02:24:03 PDT
Created attachment 69320 [details]
Patch
Comment on attachment 69320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69320&action=review > WebKit/chromium/ChangeLog:5 > + [chromium] add an identifier method to WebFrame please add some explanation here about why this is important. please document what kind of constraints you have on this identifier. that way people in the future will understand what they can and can't change about this identifier field. > WebKit/chromium/src/WebFrameImpl.cpp:267 > + // identifiers that overlap with those from past/future browser sessions. making these IDs unique across browser sessions is not a requirement is it? Created attachment 69429 [details]
Patch
Comment on attachment 69429 [details] Patch Clearing flags on attachment: 69429 Committed r68871: <http://trac.webkit.org/changeset/68871> All reviewed patches have been landed. Closing bug. |