Bug 46884

Summary: [chromium] add an identifier method to WebFrame
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2010-09-30 02:24:03 PDT
[chromium] add an identifier method to WebFrame
Attachments
Patch (3.51 KB, patch)
2010-09-30 02:24 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2010-10-01 00:41 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2010-09-30 02:24:27 PDT
Created attachment 69320 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-09-30 11:19:27 PDT
Comment on attachment 69320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69320&action=review > WebKit/chromium/ChangeLog:5 > + [chromium] add an identifier method to WebFrame please add some explanation here about why this is important. please document what kind of constraints you have on this identifier. that way people in the future will understand what they can and can't change about this identifier field. > WebKit/chromium/src/WebFrameImpl.cpp:267 > + // identifiers that overlap with those from past/future browser sessions. making these IDs unique across browser sessions is not a requirement is it?
jochen
Comment 3 2010-10-01 00:41:46 PDT
Created attachment 69429 [details] Patch
WebKit Commit Bot
Comment 4 2010-10-01 01:06:26 PDT
Comment on attachment 69429 [details] Patch Clearing flags on attachment: 69429 Committed r68871: <http://trac.webkit.org/changeset/68871>
WebKit Commit Bot
Comment 5 2010-10-01 01:06:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.