Bug 46863

Summary: glsl-conformance.html on khronos will crash chromium --in-process-webgl
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 44309    
Bug Blocks:    
Attachments:
Description Flags
patch kbr: review+, zmo: commit-queue-

Zhenyao Mo
Reported 2010-09-29 18:23:50 PDT
It's due to the HashMap resizing not being handled properly in WebGraphicsContextDefaultImpl.cpp
Attachments
patch (76.94 KB, patch)
2010-09-29 18:29 PDT, Zhenyao Mo 		kbr: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-09-29 18:29:59 PDT
Created attachment 69290 [details] patch The test is copied from khronos and slightly modified (turn off console logging).
Kenneth Russell
Comment 2 2010-09-29 18:49:15 PDT
It's unfortunate there isn't a better pattern for this but after searching through WebCore I see this pattern of HashMaps with pointers as the values in several places. Just to verify before r+'ing: the new test was run with WebKit as well as Chromium?
Zhenyao Mo
Comment 3 2010-09-29 19:30:15 PDT
Yes, tested in both Safari and Chromium.
Kenneth Russell
Comment 4 2010-09-30 10:48:50 PDT
Comment on attachment 69290 [details] patch OK. Looks good to me.
Zhenyao Mo
Comment 5 2010-09-30 11:13:08 PDT
Committed r68806: <http://trac.webkit.org/changeset/68806>
Note You need to log in before you can comment on or make changes to this bug.