Bug 46838

Summary: Get rid of marginStartUsing/setMarginStartUsing on RenderBox
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Dave Hyatt
Reported 2010-09-29 14:15:06 PDT
Get rid of marginStartUsing/setMarginStartUsing on RenderBox (and before/after/end). It's cleaner to invert the relationship and make the methods be on the containing block instead. This also allows the getters to work with RenderInlines.
Attachments
Patch (18.12 KB, patch)
2010-09-29 14:20 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (18.40 KB, patch)
2010-09-29 14:25 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-29 14:20:42 PDT
Created attachment 69247 [details] Patch
Dave Hyatt
Comment 2 2010-09-29 14:25:49 PDT
Created attachment 69248 [details] Patch
Dave Hyatt
Comment 3 2010-09-29 14:45:51 PDT
Fixed in r68687.
Note You need to log in before you can comment on or make changes to this bug.