Bug 46829

Summary: [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch jamesr: review+

Tony Chang
Reported 2010-09-29 11:37:34 PDT
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
Attachments
Patch (6.92 KB, patch)
2010-09-29 11:38 PDT, Tony Chang 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-09-29 11:38:28 PDT
Created attachment 69236 [details] Patch
Tony Chang
Comment 2 2010-09-29 11:38:52 PDT
Only tested on Lucid (-O0 and -02).
James Robinson
Comment 3 2010-09-29 13:52:39 PDT
Comment on attachment 69236 [details] Patch Code changes look good, but please compile test on a hardy box before landing. I had to revert the WebCore flip because of a bunch of hardy gcc errors that make no sense.
Tony Chang
Comment 4 2010-09-29 15:53:41 PDT
Committed r68700: <http://trac.webkit.org/changeset/68700>
Note You need to log in before you can comment on or make changes to this bug.