Bug 46829 - [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
Summary: [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 11:37 PDT by Tony Chang
Modified: 2010-09-29 15:53 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.92 KB, patch)
2010-09-29 11:38 PDT, Tony Chang
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-09-29 11:37:34 PDT
[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
Comment 1 Tony Chang 2010-09-29 11:38:28 PDT
Created attachment 69236 [details]
Patch
Comment 2 Tony Chang 2010-09-29 11:38:52 PDT
Only tested on Lucid (-O0 and -02).
Comment 3 James Robinson 2010-09-29 13:52:39 PDT
Comment on attachment 69236 [details]
Patch

Code changes look good, but please compile test on a hardy box before landing.  I had to revert the WebCore flip because of a bunch of hardy gcc errors that make no sense.
Comment 4 Tony Chang 2010-09-29 15:53:41 PDT
Committed r68700: <http://trac.webkit.org/changeset/68700>