Bug 46803

Summary: [v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: WebCore JavaScriptAssignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, ericu, loislo, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2010-09-29 06:12:54 PDT
At the moment it uses custom call to ScriptExecutionContext::reportException while the exceptions should be reported in a regular way using V8 message listener set in V8DOMWindowShell::initContextIfNeeded.
Attachments
Patch (2.04 KB, patch)
2010-09-29 06:16 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2010-09-29 06:16:44 PDT
Created attachment 69185 [details] Patch
anton muhin
Comment 2 2010-09-29 06:20:15 PDT
Comment on attachment 69185 [details] Patch LGTM, much nicer
WebKit Commit Bot
Comment 3 2010-09-29 06:47:01 PDT
Comment on attachment 69185 [details] Patch Clearing flags on attachment: 69185 Committed r68641: <http://trac.webkit.org/changeset/68641>
WebKit Commit Bot
Comment 4 2010-09-29 06:47:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.